chore: prevent launching more browsers in server mode - #36353
Merged
Simon Knott (Skn0tt) merged 7 commits intoJun 19, 2025
Conversation
| const remoteServer = await startRemoteServer('launchServer'); | ||
| const browser = await connect(remoteServer.wsEndpoint()) as any as BrowserImpl; | ||
| await expect( | ||
| browser._connection.sendMessageToServer( |
Collaborator
There was a problem hiding this comment.
I think it's easier to call browser._parent.launch(), then you won't need the guid as well.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| const browser = await playwright[browserName as 'chromium'].launch(serverSideCallMetadata(), this._options.launchOptions); | ||
| browser.options.sdkLanguage = options.sdkLanguage; | ||
|
|
||
| this._cleanups.push(async () => { |
Collaborator
There was a problem hiding this comment.
I think we still need to close browser though.
Contributor
Test results for "tests 1"1 failed 3 flaky39429 passed, 822 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.