Skip to content

chore: use different babel import in tsxTransform follow-up - #36380

Closed
Max Schmitt (mxschmitt) wants to merge 1 commit into
microsoft:mainfrom
mxschmitt:tsxTransform-import2
Closed

chore: use different babel import in tsxTransform follow-up#36380
Max Schmitt (mxschmitt) wants to merge 1 commit into
microsoft:mainfrom
mxschmitt:tsxTransform-import2

Conversation

@mxschmitt

Copy link
Copy Markdown
Contributor

@dgozman Dmitry Gozman (dgozman) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching by import type.*lib in our source reveals more such places. Should we fix them all together?

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

7 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:97:5 › mobile viewport › should fire orientationchange event @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39447 passed, 823 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt

Max Schmitt (mxschmitt) commented Jun 21, 2025

Copy link
Copy Markdown
Contributor Author

Searching by import type.*lib in our source reveals more such places. Should we fix them all together?

I guess that would mean we could also remove the tsconfig.json lib->src rewrite? While I like removing the redirects having relative imports is also something I'd not particularly like to trade in for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants