chore: use a single Progress instance for expect - #36407
Merged
Dmitry Gozman (dgozman) merged 1 commit intoJun 24, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Jun 24, 2025
Dmitry Gozman (dgozman)
force-pushed
the
chore-expect-single-progress
branch
from
June 24, 2025 18:57
100bbfb to
64dacb5
Compare
Contributor
Test results for "tests 1"3 failed 4 flaky39465 passed, 823 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
merged commit Jun 24, 2025
a41e16b
into
microsoft:main
26 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new strict progress mode, we can skip
progress.race()calls and thus avoid being interrupted by the progress.To support legacy mode, guarded by
env.PLAYWRIGHT_LEGACY_TIMEOUTS, two new methodsprogress.legacyDisableTimeout()andprogress.legacyEnableTimeout()are implemented. This will go away as soon as legacy mode is removed.Closes #36236. References #35987.