Skip to content

Revert "fix: get rid of url.parse in network code" - #36654

Merged
Simon Knott (Skn0tt) merged 2 commits into
mainfrom
revert-36423-fix-url-parse
Jul 11, 2025
Merged

Revert "fix: get rid of url.parse in network code"#36654
Simon Knott (Skn0tt) merged 2 commits into
mainfrom
revert-36423-fix-url-parse

Conversation

@Skn0tt

Copy link
Copy Markdown
Member

Reverts #36423

Closes #36650

@Skn0tt Simon Knott (Skn0tt) self-assigned this Jul 11, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node18-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node22-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node24-1
⚠️ [webkit-library] › library/browsercontext-viewport-mobile.spec.ts:206:5 › mobile viewport › view scale should reset after navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46731 passed, 926 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt
Simon Knott (Skn0tt) merged commit 7fed46b into main Jul 11, 2025
32 checks passed
@Skn0tt
Simon Knott (Skn0tt) deleted the revert-36423-fix-url-parse branch July 11, 2025 12:33
Simon Knott (Skn0tt) added a commit to Skn0tt/playwright that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Regression]: 1.54.0 breaks downloading browsers when an HTTP(S) proxy is used

2 participants