Skip to content

fix(run-server): don't share browsers - #36689

Merged
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
Skn0tt:fix-sharedbrowser
Jul 22, 2025
Merged

fix(run-server): don't share browsers#36689
Simon Knott (Skn0tt) merged 1 commit into
microsoft:mainfrom
Skn0tt:fix-sharedbrowser

Conversation

@Skn0tt

Copy link
Copy Markdown
Member

In #36369, we accidentally enabled multiclient for the connection mode that's used with run-server. While it helped us uncover #36688, we still shouldn't.

@Skn0tt Simon Knott (Skn0tt) self-assigned this Jul 15, 2025
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:76:7 › should update aria snapshot highlight @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/browsercontext-pages.spec.ts:82:3 › should click the button with offset with page scale @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46741 passed, 926 skipped
✔️✔️✔️

Merge workflow run.

@Skn0tt
Simon Knott (Skn0tt) merged commit f8764f3 into microsoft:main Jul 22, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants