Skip to content

fix(ui-mode): properly align error and warning icons in the ActionsList - #36693

Merged
Adam Gastineau (agg23) merged 1 commit into
microsoft:mainfrom
agg23:ui-mode-action-icon-position-fix
Jul 18, 2025
Merged

fix(ui-mode): properly align error and warning icons in the ActionsList#36693
Adam Gastineau (agg23) merged 1 commit into
microsoft:mainfrom
agg23:ui-mode-action-icon-position-fix

Conversation

@agg23

Copy link
Copy Markdown
Contributor

Likely regressed in #36025.

Align error and warning icons vertically within the action.

After:
Screenshot 2025-07-15 at 12 06 10 PM

Before:
Screenshot 2025-07-15 at 12 05 55 PM

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › runner.spec.ts:118:5 › should ignore subprocess creation error because of SIGINT @macos-latest-node18-1
❌ [webkit-library] › library/video.spec.ts:441:5 › screencast › should work for popups @webkit-ubuntu-22.04-node18

5 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1079:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @ubuntu-latest-node24-1
⚠️ [webkit-page] › page/elementhandle-screenshot.spec.ts:27:5 › element screenshot › should work @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

46739 passed, 926 skipped
✔️✔️✔️

Merge workflow run.

@agg23
Adam Gastineau (agg23) merged commit cb752b7 into microsoft:main Jul 18, 2025
30 of 32 checks passed
Nanne (whazor) pushed a commit to whazor/playwright-trace-viewer-plus that referenced this pull request Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants