Repository navigation
feat(ui-mode): reenables the update-snapshots option and uses a dropdown - #37098
Merged
Adam Gastineau (agg23) merged 4 commits intoAug 21, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
…i-mode-update-snapshots
Adam Gastineau (agg23)
force-pushed
the
ui-mode-update-snapshots
branch
from
August 18, 2025 19:26
31d7b47 to
908b341
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"10 flaky46615 passed, 802 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
approved these changes
Aug 20, 2025
Nanne (whazor)
pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #37007.
Enables UI Mode users to select an
--update-snapshotsoption.This basic functionality was implemented in #31841, but we put it behind a compile time flag in #31952. I am unsure as to the reasons why.
This does have the side effect of marking a test as passing, but a step as failing, when it updates an existing snapshot. I am unsure if we consider this worth fixing. If so, I suggest we do it in a future change. It still logs that there was a new snapshot written to the console, just like in a terminal reporter.