feat(api): open api needed for mcp - #39646
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMar 12, 2026
Merged
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
mcp_apis
branch
from
March 12, 2026 19:07
3de7c46 to
7a71209
Compare
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Mar 12, 2026
| The [origin] to grant permissions to, e.g. "https://example.com". | ||
|
|
||
| ## method: BrowserContext.isClosedOrClosing | ||
| * since: v1.59 |
| ### option: Locator.locator.hasNotText = %%-locator-option-has-not-text-%% | ||
| * since: v1.33 | ||
|
|
||
| ## async method: Locator.normalize |
There was a problem hiding this comment.
I don't understand where it may be needed apart from formatting and if it's formatting-specific then should be part of that api.
| `- Page Snapshot:`, | ||
| '```yaml', | ||
| (await (page as Page)._snapshotForAI()).full, | ||
| (await (page as Page).snapshotForAI()).full, |
There was a problem hiding this comment.
Suggested change
| (await (page as Page).snapshotForAI()).full, | |
| (await page.snapshotForAI()).full, |
| const locator = this.page.locator(param.selector); | ||
| try { | ||
| await locator._resolveSelector(); | ||
| await locator.normalize(); |
There was a problem hiding this comment.
Documentation doesn't say anything about when the method can throw.
Pavel Feldman (pavelfeldman)
merged commit Mar 12, 2026
43c3372
into
microsoft:main
35 of 37 checks passed
Contributor
Test results for "MCP"1 failed 5255 passed, 165 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 failed 3 flaky38698 passed, 846 skipped Merge workflow run. |
zubair-farahi121
pushed a commit
to zubair-farahi121/mcp-accessibility-scanner
that referenced
this pull request
Sep 16, 2026
…n removal) playwright-core 1.59 removed the private `_evaluateFunction` helper (microsoft/playwright#39646), which this repo's pinned 1.60 no longer exposes. As a result `browser_evaluate` threw `receiver._evaluateFunction is not a function` on every call. Port Playwright's own fix: hand the public `evaluate()` an empty function whose `toString()` returns the user-supplied source, so it serializes and runs that source without the private method, `eval`, or an `as any` cast. Add a unit test that guards against calling `_evaluateFunction` and covers both page- and element-scoped evaluation, plus an e2e smoke assertion. Document `browser_evaluate` in the README tool list. Fixes #84 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DqMQPGGdv4cDPTtRuENqxj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.