Skip to content

feat: page version of toMatchAriaSnapshot - #39950

Merged
Dmitry Gozman (dgozman) merged 2 commits into
microsoft:mainfrom
dgozman:feat-page-match-aria
Apr 1, 2026
Merged

feat: page version of toMatchAriaSnapshot#39950
Dmitry Gozman (dgozman) merged 2 commits into
microsoft:mainfrom
dgozman:feat-page-match-aria

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread packages/playwright/src/matchers/toMatchAriaSnapshot.ts Outdated
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › global-setup.spec.ts:313 › globalSetup should work for auth @macos-latest-node20

7 flaky ⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:687 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:1080 › cli codegen › should not throw csp directive violation errors `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-leaks.spec.ts:82 › click should not leak `@firefox-ubuntu-22.04-node20`

39134 passed, 846 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [msedge] › mcp/files.spec.ts:106 › clicking on download link emits download @mcp-windows-latest

6311 passed, 370 skipped


Merge workflow run.

@dgozman
Dmitry Gozman (dgozman) merged commit f6e14f9 into microsoft:main Apr 1, 2026
37 of 39 checks passed
Yury Semikhatsky (yury-s) added a commit to yury-s/playwright-java that referenced this pull request May 6, 2026
Ports the following upstream client-side PRs:

- microsoft/playwright#39767 - feat: Add `location()` to `WebError`
- microsoft/playwright#39950 - feat: page version of toMatchAriaSnapshot
- microsoft/playwright#40083 - feat(locator): add `description` option to getByRole
- microsoft/playwright#40092 - feat(expect): support pseudo-element in toHaveCSS
- microsoft/playwright#40159 - feat(tracing): add tracing.startHar / tracing.stopHar
- microsoft/playwright#40196 - chore: remove deprecated `handle` option from exposeBinding
- microsoft/playwright#40215 - feat(api): Locator.highlight({ style })
- microsoft/playwright#40219 - feat(api): Page.hideHighlight, Locator.hideHighlight, highlight() returns AutoCloseable
- microsoft/playwright#40283 - feat(locator): add drop API for files and clipboard-like data
- microsoft/playwright#40315 - feat(browser): Browser.onContext / offContext
- microsoft/playwright#40341 - feat(browsercontext): mirror Page lifecycle events on BrowserContext
- microsoft/playwright#40377 - feat(route): expose WebSocket subprotocols on WebSocketRoute
- microsoft/playwright#40606 - feat(api): unify WebError and ConsoleMessage location
- microsoft/playwright#40651 - docs: alias drop-payload Object types

Protocol shape change for FrameExpectResult.received (now `{ value, ariaSnapshot }` instead
of a bare SerializedValue) — updated AssertionsBase to unwrap it.

Generator updates: added new types to relevant import lists; share topLevelTypes between
the assertion and non-assertion generate runs so PseudoElement gets emitted into options/.
Yury Semikhatsky (yury-s) added a commit to yury-s/playwright-java that referenced this pull request May 6, 2026
Ports the following upstream client-side PRs:

- microsoft/playwright#39767 - feat: Add `location()` to `WebError`
- microsoft/playwright#39950 - feat: page version of toMatchAriaSnapshot
- microsoft/playwright#40083 - feat(locator): add `description` option to getByRole
- microsoft/playwright#40092 - feat(expect): support pseudo-element in toHaveCSS
- microsoft/playwright#40159 - feat(tracing): add tracing.startHar / tracing.stopHar
- microsoft/playwright#40196 - chore: remove deprecated `handle` option from exposeBinding
- microsoft/playwright#40215 - feat(api): Locator.highlight({ style })
- microsoft/playwright#40219 - feat(api): Page.hideHighlight, Locator.hideHighlight, highlight() returns AutoCloseable
- microsoft/playwright#40283 - feat(locator): add drop API for files and clipboard-like data
- microsoft/playwright#40315 - feat(browser): Browser.onContext / offContext
- microsoft/playwright#40341 - feat(browsercontext): mirror Page lifecycle events on BrowserContext
- microsoft/playwright#40377 - feat(route): expose WebSocket subprotocols on WebSocketRoute
- microsoft/playwright#40606 - feat(api): unify WebError and ConsoleMessage location
- microsoft/playwright#40651 - docs: alias drop-payload Object types

Protocol shape change for FrameExpectResult.received (now `{ value, ariaSnapshot }` instead
of a bare SerializedValue) — updated AssertionsBase to unwrap it.

Generator updates: added new types to relevant import lists; share topLevelTypes between
the assertion and non-assertion generate runs so PseudoElement gets emitted into options/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants