chore(test-runner): vendor the expect library - #40301
Merged
Merged
Conversation
Inlines the parts of expect@30.2.0 that Playwright actually uses into packages/playwright/src/matchers/expectLibrary.ts. Drops spy matchers, jest snapshot matchers, expect.assertions/hasAssertions, and the public addEqualityTesters API (matcher context keeps customTesters: [] so built-in matcher bodies stay unchanged). Removes the expect, @jest/get-type, and jest-util dependencies; inlines getType, isPrimitive, isPromise locally.
Removes global state plumbing (getState/setState/JEST_MATCHERS_OBJECT), dontThrow(), and unused MatcherState fields (currentTestName, testPath, expand — expand was always false, so isExpand(this.expand) is now just false). Unexports types and helpers that no caller imports.
Removes wrapUnknownMatcherProxy and the matching "helpful expect errors" tests. Accessing a nonexistent matcher now yields the native "is not a function" TypeError instead of a custom message.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
Let's cleanup package.json - sounds like expect is being pulled via packages/playwright/package.json's dev deps - that is not orderly...
Dmitry Gozman (dgozman)
force-pushed
the
vendor-expect
branch
from
April 20, 2026 12:53
458bbd1 to
5c24dfb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
approved these changes
Apr 20, 2026
Dmitry Gozman (dgozman)
force-pushed
the
vendor-expect
branch
from
April 21, 2026 09:43
5c24dfb to
8986e17
Compare
Contributor
Test results for "MCP"3 failed 2 flaky6429 passed, 976 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky41176 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "tests 2"2 failed 75 flaky273272 passed, 12555 skipped Merge workflow run. |
Contributor
Test results for "tests others"2 fatal errors, not part of any test 18674 passed, 617 skipped, 838 did not run Merge workflow run. |
Dmitry Gozman (dgozman)
merged commit Apr 21, 2026
396a39b
into
microsoft:main
109 of 116 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectlibrary (v30.2.0) intopackages/playwright/src/matchers/expectLibrary.ts, adapted and trimmed to Playwright's needs.expect.tsrewritten on top of the vendored library, no more proxies, global variables, smaller interface into the test runner, etc.