chore: migrate to TypeScript 6.0 - #40429
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dmitry Gozman (dgozman)
approved these changes
Apr 26, 2026
| } | ||
|
|
||
| function onupgrade(req: http.IncomingMessage, socket: net.Socket, head: Buffer) { | ||
| function onupgrade(this: ProxyServer, req: http.IncomingMessage, socket: net.Socket, head: Buffer) { |
Collaborator
There was a problem hiding this comment.
Why is this needed? It's not like we use this in this function.
Member
Author
There was a problem hiding this comment.
this.localAddress is used four lines below at localAddress: this.localAddress. Without the annotation TS 6 errors with this implicitly has type any - other handlers in this file (onrequest, onconnect) already declare this: ProxyServer for the same reason.
Member
Author
There was a problem hiding this comment.
Line 474
Pavel Feldman (pavelfeldman)
force-pushed
the
ts-1
branch
from
April 27, 2026 03:05
6157f1c to
1705a92
Compare
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
force-pushed
the
ts-1
branch
from
April 27, 2026 23:10
1705a92 to
b1ed2df
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
force-pushed
the
ts-1
branch
from
April 28, 2026 02:03
b1ed2df to
05c5b08
Compare
Pavel Feldman (pavelfeldman)
force-pushed
the
ts-1
branch
from
April 28, 2026 02:35
05c5b08 to
18cc01d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"13 flaky41461 passed, 847 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 6807 passed, 927 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Apr 28, 2026
7ab9991
into
microsoft:main
38 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescriptto^6.0.3and@typescript-eslint/*to^8.59.0.URLPatternextractor inutils/generate_types/overrides.d.tsto pull the instance type instead of the constructor type — root cause of the otherwise large TS 6 cascade.baseUrl,moduleResolution: "node").eslint.config.mjsto point@typescript-eslint's parser at the extension's own tsconfigs, since the root tsc now excludespackages/extension.thischecks.