feat(webkit): support connectOverCDP(transport) for direct WVPage attach - #41038
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMay 28, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
May 28, 2026
| this._ws?.close(); | ||
| return; | ||
| } | ||
| try { |
There was a problem hiding this comment.
combine these tries
Pavel Feldman (pavelfeldman)
force-pushed
the
feat-webkit-cdp-transport
branch
from
May 28, 2026 22:46
a05ab2a to
591f47d
Compare
Contributor
Test results for "MCP"7207 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 flaky43971 passed, 864 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit May 28, 2026
f14741d
into
microsoft:main
48 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnectionTransportis passed, skip the/jsontab listing and bring up a single context + singleWVPagebound to the provided transport.ConnectionTransportgains a requiredopen()so the caller can hold off starting the RDP message pump until theTarget.targetCreatedlistener is wired.