feat(firefox): roll to r1536 - #41859
Merged
Merged
Conversation
Contributor
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"4 flaky49959 passed, 1186 skipped Merge workflow run. |
Contributor
Test results for "tests 2"1 failed 19 flaky102306 passed, 4424 skipped Merge workflow run. |
Dmitry Gozman (dgozman)
approved these changes
Jul 19, 2026
This was referenced Jul 19, 2026
3 of 8 tasks
Jake Writer (JWriter20)
pushed a commit
to daijro/camoufox
that referenced
this pull request
Sep 27, 2026
Juggler set inRDMPane on every page with an emulated viewport, which is Playwright's default for new contexts. RDM is devtools' mobile mode, and a page can read it: scrollbars become overlay scrollbars with no layout width, so with classic scrollbars pinned a page measured 12 px without a viewport and 0 px with one. Navigator, screen and window getters also take RDM branches. The viewport itself is sized by the browser element and does not need RDM. Playwright's Juggler has enabled RDM only for isMobile since microsoft/playwright#41859. Do the same: Browser.setDefaultViewport and Page.setViewportSize already accept isMobile, and it is now kept and applied instead of dropped, so is_mobile=True still gets RDM. The new guard tests/patches/viewport-no-rdm.py fails on the old Juggler (0 px in a viewport context against 12 px without) and passes on this one. It also checks that is_mobile=True still turns RDM on. Five upstream Playwright tests go in ci/skiplist.yml. They assume headless scrollbars take no width, which upstream gets by hiding them with a style sheet that Camoufox removed. They only passed here because of RDM's overlay scrollbars. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 77d69ac)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser build: https://github.com/microsoft/playwright-browsers/commit/40396e89fb669a609f69de79c145cde4655ce642. Build has full platform coverage - check that all tests pass there.