chore(aria): derive yaml aria snapshots from the JSON snapshot - #42169
Conversation
2550d84 to
8aa97ea
Compare
| iframeDepths[ariaNode.ref] = depth; | ||
|
|
||
| const node: aria.AriaNodeJSON = { role: ariaNode.role }; | ||
| const node: aria.AriaNodeJSON = { role: ariaNode.role as aria.AriaNodeJSON['role'] }; |
There was a problem hiding this comment.
just do one case
Test results for "tests 1"4 flaky51353 passed, 1190 skipped Merge workflow run. |
Test results for "MCP"1 failed 8062 passed, 1284 skipped Merge workflow run. |
c873099
into
microsoft:main
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 Clear — the one failure is a known pre-existing flake
DetailsThis PR only reworks the aria snapshot renderer ( Pre-existing flake / infra
Caused by this PR
Triaged by the Playwright bot - agent run |
Make the JSON renderer the single source of the aria snapshot: type AriaNodeJSON explicitly, move yaml serialization (including codegen regex heuristics) into an isomorphic JSON=>yaml renderer, and serialize at the last moment before the yaml version is needed. Delete the duplicate yaml tree renderer and the text-based iframe snapshot merge.