Skip to content

chore(aria): derive yaml aria snapshots from the JSON snapshot - #42169

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:chore-aria-json-yaml
Aug 7, 2026
Merged

chore(aria): derive yaml aria snapshots from the JSON snapshot#42169
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:chore-aria-json-yaml

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Make the JSON renderer the single source of the aria snapshot: type AriaNodeJSON explicitly, move yaml serialization (including codegen regex heuristics) into an isomorphic JSON=>yaml renderer, and serialize at the last moment before the yaml version is needed. Delete the duplicate yaml tree renderer and the text-based iframe snapshot merge.

iframeDepths[ariaNode.ref] = depth;

const node: aria.AriaNodeJSON = { role: ariaNode.role };
const node: aria.AriaNodeJSON = { role: ariaNode.role as aria.AriaNodeJSON['role'] };

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just do one case

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:699 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`

51353 passed, 1190 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-core.spec.ts:198 › dialog-accept @mcp-windows-latest-firefox

8062 passed, 1284 skipped


Merge workflow run.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit c873099 into microsoft:main Aug 7, 2026
50 of 51 checks passed
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 Clear — the one failure is a known pre-existing flake

mcp/cli-core.spec.ts:198 › dialog-accept on mcp-windows-latest-firefox is a Firefox/Windows dialog-timing flake, unrelated to this PR's aria-snapshot refactor. Everything else in the reports is flaky-only.

Details

This PR only reworks the aria snapshot renderer (packages/injected/src/ariaSnapshot.ts, packages/isomorphic/ariaSnapshotRenderer.ts, yaml.ts, JSON→yaml serialization). It doesn't touch MCP dialog handling or the click/dialog race.

Pre-existing flake / infra

Caused by this PR

  • None found.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants