fix(har): do not stall context close when saving the har fails - #42242
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoAug 13, 2026
Merged
Conversation
Dmitry Gozman (dgozman)
approved these changes
Aug 13, 2026
Contributor
Test results for "MCP"8101 passed, 1311 skipped Merge workflow run. |
Contributor
Test results for "tests 1"1 flaky51124 passed, 1208 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Aug 13, 2026
961a599
into
microsoft:main
45 checks passed
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browserContext.close()midway: the context now always closes, and the error is thrown after the close completes. Previously the context was left in a permanent 'closing' state, stalling teardown.SerializedFS.syncAndGetError()is replaced withsync()that throws the first error once, so callers cannot accidentally drop it and the error does not stick forever.Fixes #42231