Skip to content

chore: remove fix flakes bot - it is noise - #42432

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:fix_flakes
Aug 27, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:fix_flakes

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

No description provided.

@pavelfeldman Pavel Feldman (pavelfeldman) changed the title Fix flakes chore: remove fix flakes bot - it is noise Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › snapshot-path-template.spec.ts:50 › tokens should expand property @windows-latest-node22

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:294 › screencast › should capture navigation `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:495 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/heap.spec.ts:223 › should not leak workers `@firefox-ubuntu-22.04-node20`

51291 passed, 1237 skipped


Merge workflow run.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 6f65bbb into microsoft:main Aug 27, 2026
42 of 44 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 CI is clear — the one failure is a pre-existing flake, not this PR

This PR only deletes two files under .github/workflows/ (fix-flakes.yml, fix-flakes-prompt.md). It touches no product code, no tests, and no shared helpers, so it can't change what any test does at runtime. The single red test is a known Windows timeout flake that also failed on main.

Details

Overall: the diff removes the fix-flakes bot workflow and its prompt — a workflow-config-only change. Nothing in it reaches the test suite, so it has no plausible path to a real test failure.

Pre-existing flake / infra

  • [playwright-test] › snapshot-path-template.spec.ts:50 › tokens should expand property (windows-latest-node22) — pre-existing flake. It timed out, and across the test-results DB this test is essentially always green: 2 failures in 4576 runs (0.04%), both timedOut on the same windows-latest-node22 bot. The other failure was on run 31736069705 (2026-08-13, a push to main at 961a599, no PR) — a SHA this PR can't be responsible for. Same test, same bot, same timeout signature, off this branch → flake, not caused here.

Not real failures

  • The 4 "flaky" entries in the report (video.spec.ts:736, video.spec.ts:294, video.spec.ts:495, heap.spec.ts:223) all passed on retry, so there's nothing to triage there.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/http.spec.ts:105 › http transport browser lifecycle (isolated) @mcp-ubuntu-latest-chromium

8258 passed, 1361 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 CI is clear — both failures are pre-existing flakes, not this PR

This PR only deletes two files under .github/workflows/ (fix-flakes.yml, fix-flakes-prompt.md). It touches no product code, no tests, and no shared helpers, so it can't change what any test does at runtime. Both red tests are known timeout flakes that also fail on main.

Details

Overall: the diff removes the fix-flakes bot workflow and its prompt — a workflow-config-only change (441 deletions across 2 files). Nothing in it reaches the test suite, so it has no plausible path to a real test failure.

Pre-existing flake / infra

  • [playwright-test] › snapshot-path-template.spec.ts:50 › tokens should expand property (windows-latest-node22) — pre-existing flake. It timed out, and across the test-results DB this test is essentially always green: 2 failures in 4576 runs (0.04%), both timedOut on the same windows-latest-node22 bot. The other failure was on run 31736069705 (2026-08-13, a push to main at 961a599, no PR) — a SHA this PR can't be responsible for. Same test, same bot, same timeout signature, off this branch → flake.

  • [chromium] › mcp/http.spec.ts:105 › http transport browser lifecycle (isolated) (mcp-ubuntu-latest-chromium) — pre-existing flake. It timed out, and this test flakes constantly: 32 timeouts across 9464 runs, spread over every MCP browser/OS bot (chromium, firefox, webkit, msedge; ubuntu and windows) and dozens of unrelated SHAs — including plenty of push-to-main runs this PR can't touch, e.g. 30495285489 (e4e04ac), 31123884186 (75dbf17), and 31727688105 (c756912). Same test, same timeout signature, off this branch → flake.

Not real failures

  • The 4 "flaky" entries in the "tests 1" report (video.spec.ts:736, video.spec.ts:294, video.spec.ts:495, heap.spec.ts:223) all passed on retry, so there's nothing to triage there.

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants