fix(client-certificates): reestablish a way to explicitly send no client certificate for an origin - #42547
Merged
Pavel Feldman (pavelfeldman) merged 3 commits intoSep 10, 2026
Conversation
…empty client certificates list
…rage sendNone combined with cert/key/passphrase/pfx, or mixed with a real certificate on the same origin, now throws instead of silently resolving. Adds test coverage for sendNone across fetch, browser and persistentContext, and clarifies the docs.
Yury Semikhatsky (yury-s)
approved these changes
Sep 8, 2026
| - `pfxPath` ?<[path]> Path to the PFX or PKCS12 encoded private key and certificate chain. | ||
| - `pfx` ?<[Buffer]> Direct value of the PFX or PKCS12 encoded private key and certificate chain. | ||
| - `passphrase` ?<[string]> Passphrase for the private key (PEM or PFX). | ||
| - `sendNone` ?<[boolean]> Explicitly send no client certificate for this origin. Must be the only field set besides `origin`. |
There was a problem hiding this comment.
The name reads oddly next to the other options, how about noCertificate?
Contributor
Author
There was a problem hiding this comment.
Sounds good, I'll update that to noCertificate
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
left a comment
Member
There was a problem hiding this comment.
Please do the rename and accept CLA so that we could merge the PR.
Contributor
Author
|
@microsoft-github-policy-service agree company="Seven.One Production GmbH" |
Yury Semikhatsky (yury-s)
approved these changes
Sep 10, 2026
Contributor
Test results for "tests 1"11 flaky51569 passed, 1247 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 8347 passed, 1376 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Sep 10, 2026
5967263
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the ability to explicitly send no client certificate for an origin, fixing a regression from #41113 (first released in v1.61.0).
Details
sendNoneoption to theclientCertificatestest option so we can explicitly request sending no certificate to a server rather than relying on the previous implicit "clientCertificates set, but origin not mentioned in configured origins means intercept and send no certificate"Fixes #42546