fix(fetch): preserve node error fields across serialization - #42562
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yury Semikhatsky (yury-s)
approved these changes
Sep 4, 2026
| else | ||
| e = Object.assign(new PlaywrightError(error.error.message), { name: error.error.name }); | ||
| e.stack = error.error.stack || ''; | ||
| parseSystemErrorFields(error.error, e); |
There was a problem hiding this comment.
can we just append it to the message, so that it works across langs?
Serialize the structured fields of a Node.js system error (code, errno, syscall, address, port, hostname) alongside the message, so that callers can classify network failures without parsing the error text. Fixes: microsoft#42532
Node does not always mention the code in the message, e.g. "socket hang up" is an ECONNRESET. Append it during serialization, so that clients in all languages can tell the errors apart.
Dmitry Gozman (dgozman)
force-pushed
the
fix-42532
branch
from
September 8, 2026 12:19
14b5b2e to
8b04f54
Compare
Contributor
Test results for "tests 1"6 flaky51374 passed, 1247 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 8326 passed, 1371 skipped Merge workflow run. |
Contributor
|
Hi, I'm the Playwright bot and I took a look at the CI failures. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsThis PR only changes error serialization for Pre-existing flake / infra
Triaged by the Playwright bot — agent run Triaged by the Playwright bot - agent run |
Yury Semikhatsky (yury-s)
approved these changes
Sep 8, 2026
Dmitry Gozman (dgozman)
merged commit Sep 8, 2026
fab00c0
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code,errno,syscall,address,port,hostname— alongside the message, soAPIRequestContextfailures can be classified without parsing the error text.@protocol/serializers, and copied only when the runtime type matches the protocol type.error.codeinto the error message for other languages.Fixes #42532