fix(har): do not report zero sizes for bodies that were never read - #42564
Merged
Merged
Conversation
APIRequestContext destroys the request on a redirect and on the 401 basic-auth retry before reading the body, so the har tracer recorded bodySize/content.size as 0 for those hops, contradicting the Content-Length header in the same entry. Keep the -1 "not available" sentinel instead, matching what the browser path already does. Fixes: microsoft#42370
Contributor
Test results for "tests 1"7 flaky51333 passed, 1247 skipped Merge workflow run. |
Contributor
Test results for "MCP"2 failed 8325 passed, 1371 skipped Merge workflow run. |
Yury Semikhatsky (yury-s)
approved these changes
Sep 4, 2026
Dmitry Gozman (dgozman)
merged commit Sep 4, 2026
ca667fe
into
microsoft:main
43 of 45 checks passed
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APIRequestContextdestroys the request on a redirect and on the 401 basic-auth retry before reading the body, so the har tracer recordedbodySize/content.sizeas0for those hops, contradicting theContent-Lengthheader in the same entry.-1"not available" sentinel instead, matching what the browser path already does.Fixes #42370