Skip to content

test(webkit): document a webkit transition crash from 42637 - #42640

Merged
Pavel Feldman (pavelfeldman) merged 2 commits into
microsoft:mainfrom
pavelfeldman:doc-42637
Sep 10, 2026
Merged

Pavel Feldman (pavelfeldman) merged 2 commits into
microsoft:mainfrom
pavelfeldman:doc-42637

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Ref: #42637

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread tests/page/page-transition.spec.ts Outdated

import { test as it, expect } from './pageTest';

it.only('should not crash when filter transition completes', async ({ page, browserName }) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think we want only

promise = settled();
divs.forEach(div => div.classList.remove('dim'));
await promise;
}).catch(() => {});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not fail the test if there are other issues?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably wants to tell that evaluate can fail, but it is important that it does not crash the page.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit af74c93 into microsoft:main Sep 10, 2026
42 of 43 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:173 › should work with Ctrl-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:664 › screencast › should capture full viewport `@realtime-time-library-chromium-linux`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@windows-latest-node22`

51542 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox

8347 passed, 1376 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures on this PR.

🟢 CI is clear — the one failure is a known Firefox flake

The only real failure is mcp/annotate.spec.ts:446 on mcp-windows-latest-firefox, and it's a well-established flake unrelated to this PR. This change only adds a webkit-only page-transition.spec.ts, which doesn't touch the MCP annotate flow. The tests 1 report has no real failures — just six retry-rescued flakes.

Details

Pre-existing flake / infra

  • [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate — pre-existing Firefox flake. Across the test-results DB this test failed 40 of 710 runs (~5.6%) on Firefox, spread over 707 distinct SHAs, while Chromium/Chrome/msedge/webkit are effectively green (0–2 failures each). The failures land on SHAs unrelated to this PR, and the PR touches nothing in the MCP annotate/screencast path.

  • The six entries in the tests 1 report (browsercontext-page-event.spec.ts:173, video.spec.ts:664, browsercontext-cookies-third-party.spec.ts:257/:470, page-emulate-media.spec.ts:144, ui-mode-trace.spec.ts:715) are all flaky — they passed on retry within the same run. None are in code this PR touches.

Caused by this PR

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants