Skip to content

fix(docs): document credentials, opfs, and indexeddb in storageState - #42761

Closed
Noxtimo wants to merge 1 commit into
microsoft:mainfrom
Noxtimo:fix-42732
Closed

Noxtimo wants to merge 1 commit into
microsoft:mainfrom
Noxtimo:fix-42732

Conversation

@Noxtimo

@Noxtimo Noxtimo commented Sep 17, 2026

Copy link
Copy Markdown

Summary

  • Document optional credentials (VirtualCredential array) as well as optional indexedDB and opfs origin entries in storageState return and parameter specifications across class-browsercontext.md, class-apirequestcontext.md, class-apirequest.md, and params.md.
  • Update StorageState client type definition in packages/playwright-core/src/client/types.ts and regenerate types.d.ts declarations.
  • Add regression test in tests/library/browsercontext-storage-state.spec.ts verifying static typing and round-tripping for the full snapshot structure.

Fixes #42732

@dcrousso

Copy link
Copy Markdown
Contributor

Noxtimo please either approve the above CLA or close this PR

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://cdn.playwright.dev/dbazure/download/playwright) @package-installations-macos-latest
❌ [installation tests] › playwright-cdn.spec.ts:43 › playwright cdn failover should work (https://playwright.download.prss.microsoft.com/dbazure/download/playwright) @package-installations-macos-latest

8 flaky ⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:725 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@windows-latest-node22`

51978 passed, 1247 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/http.spec.ts:343 › http transport browser lifecycle (persistent) @mcp-macos-latest-chrome
❌ [firefox] › mcp/cli-drag.spec.ts:19 › drag between elements @mcp-windows-latest-firefox

8588 passed, 1446 skipped


Merge workflow run.

@Noxtimo

Noxtimo commented Sep 18, 2026

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@dcrousso

Copy link
Copy Markdown
Contributor

please see #42732 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Python] StorageState TypedDict doesn't have credentials and opfs entries

2 participants