fix(locator-generator): keep regexes with u, s, y, d and v flags - #42819
Merged
Merged
Conversation
The generator only recognised i, g and m regex flags, so a locator such
as getByText(/foo/u) was rendered as the string literal getByText('/foo/u')
in call logs, traces, codegen and locator.toString().
Fixes microsoft#42814
Yury Semikhatsky (yury-s)
approved these changes
Sep 22, 2026
Contributor
Test results for "tests 1"5 flaky52020 passed, 1250 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 8691 passed, 1474 skipped Merge workflow run. |
Yury Semikhatsky (yury-s)
merged commit Sep 22, 2026
56c0b49
into
microsoft:main
44 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detectExactin the locator generator only matched regex flagsi,gandm, while the selector parser acceptsdgimsuvy. A regex with any other flag fell through and was quoted as a string, sogetByText(/foo/u)rendered asgetByText('/foo/u')in call logs, trace viewer, codegen andlocator.toString().Fixes #42814