fix(webkit): allow service worker navigation while offline - #42894
Devin Rousso (dcrousso) wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
🔴 The failures are this PR's own new testsAll four failures are the DetailsCaused by this PR
Not part of the verdict
Triaged by the Playwright bot - agent run |
This comment has been minimized.
This comment has been minimized.
🟢 Both MCP failures are known flakesHi, I'm the Playwright bot — I triaged the "MCP" report. Both failures are tests that flip DetailsThis PR changes one line of Pre-existing flake / infra
One caveat on the headline: this verdict covers the MCP report only. The earlier "tests 1" Triaged by the Playwright bot - agent run |
5a973e3 to
ba8797a
Compare
Test results for "tests 1"6 flaky52591 passed, 1272 skipped Merge workflow run. |
Test results for "MCP"8937 passed, 1489 skipped Merge workflow run. |
There was a problem hiding this comment.
let's drop this tests and keep coverage only for the functionality that is being fixed
offline emulation rejects navigation even when a service worker supplies the response apply configured offline state when page targets are initialized cover service worker responses on existing and newly opened pages
ba8797a to
02e243a
Compare
offline emulation rejects navigation even when a service worker supplies the response
apply configured offline state when page targets are initialized
cover service worker responses, context isolation, and reopening pages
fixes #42775