Skip to content

chore(server): remove unused noAutoWaiting action option - #42901

Merged
Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-remove-no-auto-waiting
Sep 25, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
microsoft:mainfrom
dgozman:chore-remove-no-auto-waiting

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • The only real setters of noAutoWaiting were removed together with "perform" in chore: rip perform #39626; since then it was only reachable through the __testHookNoAutoWaiting test hook.
  • Drop the option from server action types and retry helpers, and remove the corresponding tests.

The only real setters of noAutoWaiting were removed together with
"perform" in microsoft#39626. Since then it was only reachable through the
__testHookNoAutoWaiting test hook.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/launch.spec.ts:96 › persistent context @mcp-macos-latest-chrome
❌ [firefox] › mcp/idle-timeout.spec.ts:19 › closes the browser after the idle timeout and relaunches it on the next call @mcp-windows-latest-firefox

8703 passed, 1474 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/popup.spec.ts:260 › should not throw when click closes popup `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:521 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@windows-latest-node22`

52228 passed, 1241 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the failing CI here.

🟡 One confirmed flake, one I can't pin down

mcp/idle-timeout.spec.ts:19 is a known pre-existing flake. mcp/launch.spec.ts:96 has never failed before in the results I have, so I can't call it either way — though this PR only deletes dead noAutoWaiting code, which the MCP launch path doesn't touch.

Details

The diff removes the noAutoWaiting option from dom.ts::_retryAction, frames.ts::_retryWithProgressIfNotConnected and server/types.ts, plus the three page-click.spec.ts tests that drove it via __testHookNoAutoWaiting. There are no other setters left in the tree, so nothing outside that test hook changes behaviour — and neither failing test is an MCP click/action test.

Pre-existing flake / infra

Uncertain

  • [chrome] › mcp/launch.spec.ts:96 › persistent context (mcp-macos-latest-chrome) — Test timeout of 30000ms exceeded. MCPError: MCP error -32000: Connection closed. This is the only failure for this test in 741 runs in the DB, so I have no prior occurrence to call it a flake. What makes me doubt the PR caused it: the error is a dropped MCP connection during browser launch, the same test passed on every other project/bot in this very run, and the diff touches only element-action retry logic. A rerun would settle it — if it goes green, it's noise.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit 0404a2c into microsoft:main Sep 25, 2026
45 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants