Skip to content

fix(net): honor ipv4first dns result order in dual-stack lookup - #42906

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42799
Sep 24, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42799

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • dualStackLookup always tried IPv6 first and ignored --dns-result-order=ipv4first; it now tries IPv4 first when the process-wide DNS result order is set to ipv4first.
  • On networks where IPv6 is set up but not routed, this lets users skip the 5s wait before Node falls back to IPv4. The download timeout itself was fixed in fix(net): apply socketTimeout from socket creation in httpRequest #42660.

Fixes #42799

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52270 passed, 1241 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chromium] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-windows-latest-chromium
❌ [firefox] › mcp/cli-core.spec.ts:149 › upload multiple files @mcp-windows-latest-firefox

8710 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a look at the CI failures here.

🟢 Both failures are pre-existing flakes — the PR is clear

mcp/annotate.spec.ts:110 and mcp/cli-core.spec.ts:149 both fail with the same error signatures on main and on unrelated PRs. This PR only changes dualStackLookup in packages/utils/network.ts, which the MCP annotate and file-upload flows don't touch.

Details

The diff is two files: family ordering in dualStackLookup (packages/utils/network.ts) and a new test in tests/library/network-timeout.spec.ts. The new test passed; the tests 1 run was fully green apart from four unrelated flakes. The only red is the MCP shard, and neither failing test resolves a hostname through dualStackLookup.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Browser downloads time out (30000ms) on dual-stack/VPN environments due to broken Happy Eyeballs in dualStackLookup

2 participants