Skip to content

fix(route): do not drop requests matching case-insensitive URLPattern - #42920

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42918
Sep 24, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:fix-42918

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • URLPattern doesn't expose ignoreCase, so the server rebuilt patterns as case-sensitive and skipped routing for matching requests.
  • The server now always matches case-insensitively. This is a safe superset, and the client filters again with the original pattern.

Fixes #42918

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium-library] › library/screencast.spec.ts:28 › screencast.start delivers frames via onFrame callback `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/browsercontext-page-event.spec.ts:160 › should work with Shift-clicking `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52295 passed, 1255 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [firefox] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) @mcp-ubuntu-latest-firefox
❌ [firefox] › mcp/cli-core.spec.ts:123 › select @mcp-windows-latest-firefox

8736 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 Both failures are pre-existing flakes

The two Firefox MCP failures have failed the same way on other PRs and on main pushes, and this PR only touches route URL matching (packages/isomorphic/urlMatch.ts), which neither test exercises.

Details

The "tests 1" report has only flaky tests, no failures. The only hard failures are the two in the "MCP" report. Neither test uses page.route or URL patterns, so the diff doesn't reach them.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit df9cbf1 into microsoft:main Sep 24, 2026
43 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: URLPattern ignoreCase is lost in page.route() and browserContext.route()

2 participants