fix(chromium): allow more screencast frames in flight - #42929
Dmitry Gozman (dgozman) merged 1 commit into
Conversation
Chromium stops capturing screencast frames once 3 frames are sent without an ack. Under heavy load the ack is occasionally delayed by 30-50ms, which drops frames from the recording. Raise the limit to 5, and to 10 when recording at more than 30 fps.
Test results for "tests 1"4 flaky52280 passed, 1255 skipped Merge workflow run. |
Test results for "MCP"1 failed 8750 passed, 1480 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing flake
DetailsThe latest reports for head Pre-existing flake / infra
The test types into the input and then takes a snapshot right away, with no wait in between. That looks like a timing race in the test, not a product regression. Triaged by the Playwright bot - agent run |
4536101
into
microsoft:main
Summary
maxFramesInFlight: 5toPage.startScreencast, and10when recording at more than 30 fps. Plumbfpsfrom the screencast client to the page delegate for that.