Skip to content

feat(webkit): roll to r2368 - #42943

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2368
Sep 28, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
mainfrom
roll-into-pw-webkit/2368

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/6ba1e83b2b7db9c5f78ad7618eec1b3bc93758cc. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

6 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167 › should update tracing network live `@windows-latest-node22`

52298 passed, 1243 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

8764 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

7 failed
❌ [chromium-page] › page/page-screenshot.spec.ts:504 › page screenshot › should take fullPage screenshots during navigation @tracing-chromium
❌ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot @chromium-macos-15-xlarge
❌ [firefox-page] › page/page-keyboard.spec.ts:72 › should not type text with Alt modifier @firefox-macos-15-large
❌ [firefox-page] › page/page-keyboard.spec.ts:136 › should report shiftKey @firefox-macos-15-large
❌ [firefox-page] › page/page-keyboard.spec.ts:72 › should not type text with Alt modifier @firefox-macos-15-xlarge
❌ [firefox-page] › page/page-keyboard.spec.ts:136 › should report shiftKey @firefox-macos-15-xlarge
❌ [android-page] › page/page-set-content.spec.ts:57 › should include shadow roots

32 flaky ⚠️ [electron-page] › page/page-add-init-script-callback.spec.ts:50 › should pass arguments to the callback `@electron-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:526 › emulate media should not be affected by second connectOverCDP with noDefaults `@msedge-windows-latest`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-device.spec.ts:33 › device › should support clicking `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-events.spec.ts:30 › console event should work with element handles `@chromium-macos-15-large`
⚠️ [chromium-library] › library/screencast.spec.ts:28 › screencast.start delivers frames via onFrame callback `@chromium-macos-15-large`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:436 › should produce network events, routing, and annotations for Service Worker (advanced) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:202 › cli codegen › should upload a file via hidden input triggered by button `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:503 › selector generator › should use the name attributes for elements that can have it `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-viewport.spec.ts:154 › should set both screen and viewport options `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/channels.spec.ts:230 › should work with the domain module `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/defaultbrowsercontext-1.spec.ts:89 › should support viewport option `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/tracing.spec.ts:533 › should produce screencast frames scale `@webkit-macos-15-xlarge`
⚠️ [android-page] › page/locator-click.spec.ts:20 › should work Radoslav Kirilov (@smoke)
⚠️ [android-page] › page/page-request-fulfill.spec.ts:81 › should fulfill with unuassigned status codes

112501 passed, 4782 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 None of the failures look caused by this PR

This PR only bumps the WebKit revision in browsers.json (2367 → 2368). None of the 7 failures are on WebKit. They are either known failures on main or failures inherited from the base commit.

Details

The diff only affects which WebKit build gets downloaded. The failing tests run on Chromium, Firefox and Android, which this PR doesn't reach. I checked each one against the aggregated test-results DB. (The update step hit a GitHub API 500, so I used the latest shared snapshot.)

Inherited from the base commit (main @ b9a34ac)

  • [firefox-page] › page/page-keyboard.spec.ts:136 › should report shiftKey and :72 › should not type text with Alt modifier fail on firefox-macos-15-large and -xlarge. The branch's merge base is b9a34ac (test(firefox): Alt+key should not type text on macOS #42935). That commit adds the Alt-modifier test and removes it.fail(browserName === 'firefox' && platform === 'darwin') from should report shiftKey. Before that change, should report shiftKey failed in every recorded run on those two bots: 309/309 and 310/310, so it was expected to fail. With the annotation gone, it now counts as a real failure. The new Alt test covers the same macOS Firefox Alt-modifier behaviour, so it probably needs a Firefox build that isn't in browsers.json yet. It's new, so the DB has no history for it. main should show the same failures once tests 2 runs on b9a34ac. This is Firefox-only and has nothing to do with a WebKit roll.

Pre-existing flake / known failure

Triaged by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit 36eb29a into main Sep 28, 2026
70 of 75 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the roll-into-pw-webkit/2368 branch September 28, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant