Skip to content

feat(api): return Disposable from Tracing.start and Tracing.startChunk - #42970

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:tracing-start-disposable
Sep 29, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:tracing-start-disposable

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • tracing.start() and tracing.startChunk() now return a Disposable, matching screencast.start(), tracing.startHar() and tracing.group().
  • Disposing stops tracing (or the chunk) without saving, same as calling stop() / stopChunk() without a path.

Disposing stops tracing or the chunk without saving it, same as calling
stop or stopChunk without a path.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › should capture full viewport `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-page] › page/workers.spec.ts:191 › should attribute network activity for worker inside iframe to the iframe `@chromium-ubuntu-22.04-node24`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52316 passed, 1243 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/cli-core.spec.ts:97 › fill @mcp-windows-latest-firefox

8763 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 The only failure is a known flake — the PR is clear

[firefox] › mcp/cli-core.spec.ts:97 › fill on mcp-windows-latest-firefox fails on main and on unrelated PRs too.

Details

This PR changes Tracing.start/Tracing.startChunk to return a Disposable: client/tracing.ts, types, docs, and tracing.spec.ts. None of that is on the MCP CLI fill path.

Pre-existing flake / infra

I couldn't refresh the DB for the latest runs because the GitHub API returned a 500. The failures above are already in the snapshot and are enough to confirm this is a flake.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 716a5d3 into microsoft:main Sep 29, 2026
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants