Skip to content

fix(chromium): report local frames of existing oopifs when connecting over CDP - #43000

Open
Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:fix-42955
Open

Dmitry Gozman (dgozman) wants to merge 1 commit into
microsoft:mainfrom
dgozman:fix-42955

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

Summary

  • Handle Page.getFrameTree in OOPIF sessions the same way as in the main session, so that local child frames of an already existing OOPIF are registered and get a utility world.
  • When an iframe target has an unknown parentFrameId, attach it as a child of the main frame instead of replacing the main frame.

Fixes #42955

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

8 flaky ⚠️ [chromium-library] › library/browsertype-connect.spec.ts:990 › run-server › socks proxy › should proxy requests from fetch api over ipv6 `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/beforeunload.spec.ts:130 › should support dismissing the dialog multiple times `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-library] › library/video.spec.ts:356 › screencast › should work for popups `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-trace.spec.ts:715 › should indicate current test status `@windows-latest-node22`

52410 passed, 1243 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [chromium] › mcp/http.spec.ts:145 › http transport browser sigint @mcp-windows-latest-chromium

8828 passed, 1480 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failure here.

🟢 The one failure is a pre-existing flake

mcp/http.spec.ts:145 › http transport browser sigint failed on Windows only. This test fails on Windows every so often, including on main, and this PR's changes don't reach it.

Details

The merged MCP report (run 36637111129) has one failure and 8828 passes. This PR only changes how Chromium reports OOPIF frames on CDP connect (crPage.ts) and its test (library/chromium/oopif.spec.ts). The MCP HTTP-transport SIGINT shutdown test doesn't use that code path.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: connectOverCDP replaces the page's main frame with a nested sandboxed iframe when its parentFrameId is unknown

2 participants