Skip to content

docs(locators): recommend within() for combining locators - #43031

Merged
Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:docs-within-locators
Oct 1, 2026
Merged

Yury Semikhatsky (yury-s) merged 1 commit into
microsoft:mainfrom
yury-s:docs-within-locators

Conversation

@yury-s

Copy link
Copy Markdown
Member

Summary

  • Locators guide uses saveButton.within(dialog) instead of dialog.locator(saveButton)
  • Drop the "same as locator(locator)" sentence from Locator.within docs

Follow-up to #42887

@yury-s
Yury Semikhatsky (yury-s) merged commit bf587e9 into microsoft:main Oct 1, 2026
41 of 43 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the docs-within-locators branch October 1, 2026 00:41
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 flaky ⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`

52575 passed, 1270 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/files.spec.ts:201 › closing browser during download does not crash the server @mcp-windows-latest-chrome
❌ [webkit] › mcp/sse.spec.ts:196 › sse transport browser lifecycle (persistent) @mcp-ubuntu-latest-webkit

8935 passed, 1489 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants