Skip to content

feat(chromium): roll to r1248 - #43046

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-chromium/1248
Oct 2, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
roll-into-pw-chromium/1248

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/9c3d7d24ff6b4643eddf686419f190c1e3c84b1e. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:725 › screencast › should capture full viewport on hidpi `@chromium-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-ubuntu-22.04-node20`
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145 › should watch all `@windows-latest-node22`

52559 passed, 1270 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5 failed
❌ [firefox] › mcp/cli-core.spec.ts:43 › click button @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-core.spec.ts:394 › --raw on command without output @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-drag.spec.ts:19 › drag between elements @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-save-as.spec.ts:26 › screenshot @mcp-windows-latest-firefox
❌ [firefox] › mcp/cli-save-as.spec.ts:48 › screenshot --filename @mcp-windows-latest-firefox

8932 passed, 1489 skipped


Merge workflow run.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight @firefox-macos-15-large

37 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/browsercontext-user-agent.spec.ts:110 › should work for navigator.userAgentData and sec-ch-ua headers `@msedge-windows-latest`
⚠️ [chromium-page] › page/page-add-init-script-callback.spec.ts:50 › should pass arguments to the callback `@chromium-macos-15-large`
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:80 › should connect when an existing page has been discarded `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1934 › should not leak recorders `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:521 › screencast › should capture static page in persistent context Radoslav Kirilov (@smoke) `@chromium-macos-14-xlarge`
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:179 › should take screenshot `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › should work with video+trace `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:179 › serviceWorker(), and fromServiceWorker() work `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:301 › should report intercepted service worker requests in HAR `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:373 › should produce network events, routing, and annotations for Service Worker `@chrome-windows-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:213 › should intercept service worker requests (main and within) `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/selector-generator.spec.ts:280 › selector generator › should not use generated id `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:412 › selector generator › should not use input[value] `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:556 › selector generator › should generate title selector `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:633 › selector generator › should generate exact role when necessary `@chrome-macos-latest`
⚠️ [chromium-library] › library/selector-generator.spec.ts:693 › selector generator › should generate noText: ignore aria-labelledby pointing inside the element `@chrome-macos-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@tracing-firefox`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › should not print context options method override in mstest if no options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › should print context options method override in xunit if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:245 › should print a valid basic program in mstest `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:125 › should print a valid basic program in junit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:104 › should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-windows-latest`
⚠️ [firefox-library] › library/signals.spec.ts:25 › should close the browser when the node process closes `@firefox-windows-latest`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:257 › third party 'Partitioned;' cookies `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/browsercontext-cookies-third-party.spec.ts:470 › top level 'Partitioned;' cookie and same origin iframe `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/inspector/cli-codegen-csharp.spec.ts:28 › should print the correct imports and context options `@webkit-windows-latest`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:1171 › should filter local paths from unsafe launch options `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:813 › launchServer › should upload a folder `@webkit-macos-15-large`
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:258 › run-server › should send extra headers with connect request `@webkit-macos-15-large`

112974 passed, 4890 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 The failure is a confirmed pre-existing flake

The PR is clear. The Firefox/macOS failure has the same signature on the PR's exact base SHA, while this PR only rolls Chromium metadata and protocol definitions.

Details

Pre-existing flake

  • [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › should update aria snapshot highlight — failed on base SHA 46c9a533 before this PR (run) with the same alternating outcomes: x-pw-highlight was either missing or resolved to two elements. Across 74 recent Firefox/macOS runs, it failed 40 times and passed 34 times, including several retry-rescued runs. The PR does not touch Firefox, the recorder, or this test.

Triaged by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit a47fcf5 into main Oct 2, 2026
99 of 104 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the roll-into-pw-chromium/1248 branch October 2, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant