chore(chromium): close pages that crashed before connecting over CDP - #43075
Merged
Dmitry Gozman (dgozman) merged 1 commit intoOct 3, 2026
Merged
Conversation
Follow-up to microsoft#42936. References: microsoft#41714
Contributor
Test results for "tests 1"3 flaky52546 passed, 1270 skipped Merge workflow run. |
Contributor
Test results for "MCP"8944 passed, 1495 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #42936.
_onTargetCrashed, instead of being special-cased inPage._markInitialized.Inspector.enableis sent together with the other initialization commands, and the flag moved fromBrowserContext._skipCrashedPagestoCRBrowser._isConnecting.playwright-cli attach --cdpwith a crashed page.References #41714