feat(mcp): allow creating tabs in isolated browser contexts - #43087
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoOct 3, 2026
Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
`browser_tabs` with `action: 'new'` accepts an optional `isolatedContext` name. Tabs with the same name share cookies and storage, tabs in different contexts (or the default one) are fully isolated. The CLI exposes it as `tab-new --isolated-context=<name>`. Context keeps all browser contexts in one map, applies init scripts, origin filters and routes to each of them, and tracing and video span all contexts. Cookie, storage and network tools act on the current tab's context.
Yury Semikhatsky (yury-s)
approved these changes
Oct 3, 2026
| private _browserContextPromise: Promise<playwrightTypes.BrowserContext> | undefined; | ||
| private _defaultBrowserContext: playwrightTypes.BrowserContext; | ||
| // Keyed by isolated context name, undefined for the default context. | ||
| // Resolves once the context exists and has routes, init scripts and page listeners installed. |
There was a problem hiding this comment.
drop the comment?
| this._tabs.length = 0; | ||
| this._setCurrentTab(undefined); | ||
| await this.stopVideoRecording(); | ||
| await Promise.all([...this._browserContexts].filter(([isolatedContext]) => isolatedContext).map(([, browserContext]) => browserContext.then(c => c.close()).catch(() => {}))); |
There was a problem hiding this comment.
can context name be '' ?
| async startVideoRecording(fileName: string, params: VideoParams) { | ||
| if (this._video) | ||
| throw new Error('Video recording has already been started.'); | ||
| await this.ensureBrowserContext(); |
There was a problem hiding this comment.
will it also start video for a context created later?
Member
Author
There was a problem hiding this comment.
Video is wired per page.
| } | ||
|
|
||
| private async _setupRequestInterception(context: playwrightTypes.BrowserContext) { | ||
| private async _setupRequestInterception(context: playwrightTypes.BrowserContext, disposables: Disposable[]) { |
There was a problem hiding this comment.
should it also add entries from this._routes ?
Member
Author
There was a problem hiding this comment.
yes, in _initializeBrowserContext
Contributor
Test results for "tests 1"6 flaky52485 passed, 1268 skipped Merge workflow run. |
Contributor
Test results for "MCP"1 failed 9014 passed, 1489 skipped Merge workflow run. |
Pavel Feldman (pavelfeldman)
merged commit Oct 3, 2026
c2a031e
into
microsoft:main
45 of 46 checks passed
Contributor
🟢 The failure is a pre-existing flakeHi, I'm the Playwright bot and I triaged the MCP failure. The same test has failed with the same session-selection assertion on unrelated PRs, so this does not look caused by this change. DetailsThis PR changes shared MCP browser-context lifecycle and therefore reaches adjacent screencast code, but the failure is an established Windows/Firefox flake rather than a new correlation with this branch. Pre-existing flake / infra
Triaged by the Playwright bot - agent run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser_tabsaction: 'new'takes an optionalisolatedContextname; tabs with the same name share cookies and storage, different names (or the default context) are fully isolatedtab-new <url> --isolated-context=<name>; tab list and page header show the context name