Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Replace LSP ranges with Q# ranges#530

Merged
bamarsha merged 8 commits into
feature/position-cleanupfrom
samarsha/replace-lsp-range
Jul 27, 2020
Merged

Replace LSP ranges with Q# ranges#530
bamarsha merged 8 commits into
feature/position-cleanupfrom
samarsha/replace-lsp-range

Conversation

@bamarsha

@bamarsha bamarsha commented Jul 23, 2020

Copy link
Copy Markdown
Contributor

Replaces the LSP range type with the Q# compiler range type everywhere, except where an LSP message is being created that actually needs an LSP range.

Part of #506.

@bamarsha
bamarsha marked this pull request as ready for review July 23, 2020 19:36

@ScottCarda-MS ScottCarda-MS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Sarah!

@bamarsha
bamarsha merged commit 458d8cd into feature/position-cleanup Jul 27, 2020
@bamarsha
bamarsha deleted the samarsha/replace-lsp-range branch July 27, 2020 17:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants