This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Detect absence of .NET SDK 3.1 and display error message#753
Merged
Conversation
bamarsha
marked this pull request as draft
November 24, 2020 20:45
bamarsha
reviewed
Nov 24, 2020
vxfield
marked this pull request as ready for review
November 24, 2020 22:26
Contributor
|
We should bring this change into |
bamarsha
reviewed
Nov 24, 2020
bamarsha
reviewed
Nov 24, 2020
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
Co-authored-by: Sarah Marshall <33814365+samarsha@users.noreply.github.com>
ricardo-espinoza
approved these changes
Nov 25, 2020
bettinaheim
reviewed
Nov 25, 2020
bettinaheim
left a comment
Contributor
There was a problem hiding this comment.
I think that will work fine together with packaging a suitable global.json with the server, and setting the working directory to the server path.
bettinaheim
reviewed
Nov 25, 2020
| @@ -121,7 +126,6 @@ private static int Run(Options options) | |||
| catch (Exception ex) | |||
| { | |||
| Log("[ERROR] MsBuildLocator could not register defaults.", options.LogFile); | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Log("[ERROR] MsBuildLocator could not register defaults.", options.LogFile); | |
| Log("[ERROR] MsBuildLocator could not register defaults.", options.LogFile); | |
| // Don't exit here, since exiting without establishing a connection will result in a cryptic failure of the extension. | |
| // Instead, we proceed to create a server instance and establish the connection. | |
| // Any errors can then be properly processed via the standard server-client communication as needed. | |
bettinaheim
approved these changes
Nov 25, 2020
This was referenced Nov 25, 2020
vxfield
added a commit
that referenced
this pull request
Dec 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a mitigation of issue #737.