Repository navigation
Use new parser from vs-solutionpersistence to later enable .slnx support - #644
Merged
Meera Ruxmohan (mruxmohan4) merged 4 commits intoJun 1, 2026
Merged
Conversation
Meera Ruxmohan (mruxmohan4)
force-pushed
the
dev/mruxmohan/slnx
branch
7 times, most recently
from
January 9, 2025 10:47
8f9f182 to
d4f1f1b
Compare
|
slngen's command line options are consider adding upcoming dotnet SDK 9.0.2xx (and v10 from daily builds) has dotnet new sln --help
...
Template options:
-f, --format <sln|slnx> Choose the format for the solution file: sln or slnx.
Type: choice
sln Solution file
slnx XML Solution file
Default: slnsee the feedback from VS team about naming/terminology dotnet/sdk#44469 (comment) |
Meera Ruxmohan (mruxmohan4)
force-pushed
the
dev/mruxmohan/slnx
branch
3 times, most recently
from
January 23, 2025 17:13
ef42fb3 to
5c5f022
Compare
|
Meera Ruxmohan (@mruxmohan4) any plans to revive this? |
kasperk81
reviewed
May 21, 2025
Open
Meera Ruxmohan (mruxmohan4)
force-pushed
the
dev/mruxmohan/slnx
branch
3 times, most recently
from
October 22, 2025 17:28
7e2198c to
d536f8f
Compare
…net10 The NET10_0_OR_GREATER branch assumed solution folders moved out of ProjectsInOrder into a private SolutionFoldersByGuid dictionary in MSBuild 17.13+. In practice, when SolutionFile.Parse loads a legacy .sln (as produced by SlnFile.Save here), SolutionFoldersByGuid is empty and folders remain in ProjectsInOrder. Fall back to enumerating ProjectsInOrder when the reflection lookup yields no match. Filtering by SolutionProjectType.SolutionFolder also prevents the helper from accidentally returning a project that happens to share a name with a folder. Fixes the 7 unit tests that failed on net10: - ProjectSolutionFolders - WithFoldersDoNotIgnoreMainProject - WithFoldersIgnoreMainProject - WithFoldersDoesNotCreateRootFolder (x4 parameterized cases) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Meera Ruxmohan (mruxmohan4)
force-pushed
the
dev/mruxmohan/slnx
branch
from
May 26, 2026 22:39
d536f8f to
0a48ec2
Compare
Adds a -f|--format option to ProgramArguments allowing the user to choose the extension/format of the auto-generated solution file. When --solutionfile is specified, its extension still determines the serializer (via SolutionPersistence GetSerializerByMoniker), so the --format switch only affects the default filename when no explicit solution file is provided. Addresses kasperk81's review suggestion on PR microsoft#644. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Meera Ruxmohan (mruxmohan4)
marked this pull request as ready for review
May 27, 2026 22:35
David Federman (dfederm)
approved these changes
Jun 1, 2026
Meera Ruxmohan (mruxmohan4)
enabled auto-merge (squash)
June 1, 2026 21:53
David Federman (dfederm)
approved these changes
Jun 1, 2026
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change performs the following:
From initial local testing:
SolutionConfigurationPlatformsglobal sectionProjectConfigurationPlatformsglobal section pertained to project guids (however, order remained the same), which is expected behaviorSolutionItemsproject sectionSolutionPropertiesandExtensibilityGlobals, apart from the solution guid, which is recreated upon each slngen invocation