Introduce strategies for test ID generation - #1306
Conversation
2f839f9 to
1e0ba6a
Compare
1e0ba6a to
3e82f7a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3e82f7a to
469ddd5
Compare
6e0148c to
3ab0011
Compare
Medeni Baykal (Haplois)
left a comment
There was a problem hiding this comment.
How is this going? Would you like any help Amaury Levé (@Evangelink)?
|
Hey thanks for asking Medeni Baykal (@Haplois). Looks like I just need to fix CI tests (they are passing locally for me). There are still some tickets open (not fixed by this change) that I need to investigate but I feel confident we will be able to merge this one soon(TM). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3ab0011 to
d349ee9
Compare
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Medeni Baykal (@Haplois) please feel free to do a review when you have some free time.
|
Thanks for the review guys! Medeni Baykal (@Haplois) What do you mean by the bail-out strategy? |
|
See my comment above on the code. |
6896179
|
Marco Rossignoli (@MarcoRossignoli) Medeni Baykal (@Haplois) I have addressed all comments, if you want to have another look. Medeni Baykal (@Haplois) There is one open question remaining for you. |
|
Amaury Levé (@Evangelink) uploaded a patch file for the broken ID gen. Can't push to this branch anymore. |
|
Medeni Baykal (@Haplois) I have applied and updated your patch. Let me know if you have any other comment or if I can move forward with merging the PR. |
Fixes #1286 and fixes AB#1634557
TODO: