Skip to content

Introduce strategies for test ID generation - #1306

Merged
Amaury Levé (Evangelink) merged 12 commits into
mainfrom
dev/haplois/id-gen
Oct 27, 2022
Merged

Introduce strategies for test ID generation#1306
Amaury Levé (Evangelink) merged 12 commits into
mainfrom
dev/haplois/id-gen

Conversation

@Evangelink

@Evangelink Amaury Levé (Evangelink) commented Oct 3, 2022

Copy link
Copy Markdown
Member

Fixes #1286 and fixes AB#1634557

TODO:

  • Add comments
  • Add tests

Comment thread src/Adapter/MSTest.TestAdapter/Extensions/TestCaseExtensions.cs Outdated
Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs
@Haplois

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Haplois Medeni Baykal (Haplois) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this going? Would you like any help Amaury Levé (@Evangelink)?

@Evangelink

Copy link
Copy Markdown
Member Author

Hey thanks for asking Medeni Baykal (@Haplois). Looks like I just need to fix CI tests (they are passing locally for me). There are still some tickets open (not fixed by this change) that I need to investigate but I feel confident we will be able to merge this one soon(TM).

@Evangelink

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Evangelink Amaury Levé (Evangelink) left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medeni Baykal (@Haplois) please feel free to do a review when you have some free time.

Comment thread src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs
Comment thread src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs
Comment thread src/Adapter/MSTest.TestAdapter/Execution/TestClassInfo.cs
Comment thread src/Adapter/MSTest.TestAdapter/Extensions/TestCaseExtensions.cs Outdated
Comment thread test/E2ETests/Automation.CLI/DiscoveryEventsHandler.cs Outdated
Comment thread src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumerator.cs
Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs Outdated
Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs Outdated
Comment thread src/Adapter/MSTest.TestAdapter/PublicAPI/PublicAPI.Unshipped.txt
Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs
Comment thread src/TestFramework/TestFramework/PublicAPI/PublicAPI.Unshipped.txt
Comment thread test/E2ETests/Automation.CLI/DiscoveryEventsHandler.cs Outdated
Comment thread test/E2ETests/DiscoveryAndExecutionTests/TestId.DefaultStrategy.cs Outdated

@Haplois Medeni Baykal (Haplois) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing bail-out strategy might cause issues for some users, we need to rethink that, or at lease do a version increment. My approval is grey now :(

@Evangelink

Copy link
Copy Markdown
Member Author

Thanks for the review guys!

Medeni Baykal (@Haplois) What do you mean by the bail-out strategy?

@Haplois

Copy link
Copy Markdown
Contributor

See my comment above on the code.

Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs Outdated
@Evangelink

Copy link
Copy Markdown
Member Author

Marco Rossignoli (@MarcoRossignoli) Medeni Baykal (@Haplois) I have addressed all comments, if you want to have another look. Medeni Baykal (@Haplois) There is one open question remaining for you.

@Haplois

Copy link
Copy Markdown
Contributor

Amaury Levé (@Evangelink) uploaded a patch file for the broken ID gen. Can't push to this branch anymore.

@Evangelink

Copy link
Copy Markdown
Member Author

Medeni Baykal (@Haplois) I have applied and updated your patch. Let me know if you have any other comment or if I can move forward with merging the PR.

Comment thread src/Adapter/MSTest.TestAdapter/ObjectModel/UnitTestElement.cs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce strategies for test ID generation

3 participants