clang-format/tidy version comparisons fail for some builds#12813
Conversation
sean-mcmanus
left a comment
There was a problem hiding this comment.
It seems theoretically possible for a custom clang build to omit a patch version, but I don't think that's normal so maybe it's okay to not support that.
|
Is this for 1.22.8 or 1.23.0? |
I suppose we can wait to see if that's a capability people ask for. |
I don't have a strong opinion. If it's not in 1.22, we may be doing a 1.23.0 pre-release shortly after. |
It sounds like 1.22.8 will be a pre-release still so it seems safe enough to go into that. |
|
ok. I'll merge this in now. |
Fixes: #12806
Use regular expressions to find the version number instead of token position.