Formatting a notebook results in having the last cell's code pasted into every cell. It also doesn't format the notebook.

[greazer]

Version: 1.60.0-insider (user setup)
Commit: 58454f7
Date: 2021-08-13T05:15:29.421Z
Electron: 13.1.8
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Python: v2021.9.1125171759-dev
Jupyter: v2021.8.2027072902
Pylance: v2021.8.2-pre.1

1. Open a notebook. I used the one from https://github.com/greazer/covid-19-data/tree/master/SampleNbsAndScripts
2. Right click on the first code cell and choose Format Notebook...

A lot of activity will occur (based on the progress bar spinning for a few seconds), but the only formatting that will have happened is that code from the last cell in the notebook will be pasted into the top of every cell.

Clearly this is wrong. :)

[vscode-triage-bot]

Pinging notebook topic followers: Claudia Regio (@claudiaregio) Rich Chiodo (@rchiodo) Jim Griesmer (@greazer) Don Jayamanne (@DonJayamanne) jilljac (@jilljac) Ian Huff (@IanMatthewHuff) tanhakabir Paige Bailey (@dynamicwebpaige)

[greazer]

Direct assignment to Peng Lyu (@rebornix) just cuz of how unexpected this behavior is. :)

[rebornix]

We now request cell formatting in parallel (cc Joyce Er (@joyceerhl)) but it seems Python extension generates temp file for notebook cell formatting but it only uses uri.fsPath and doesn't include fragment, thus all notebook cells are using the same temp file for formatting.

vscode-python/src/client/common/editor.ts

Lines 241 to 263 in a478613

	export async function getTempFileWithDocumentContents(document: TextDocument, fs: IFileSystem): Promise<string> {
	// Don't create file in temp folder since external utilities
	// look into configuration files in the workspace and are not
	// to find custom rules if file is saved in a random disk location.
	// This means temp file has to be created in the same folder
	// as the original one and then removed.
	// Use a .tmp file extension (instead of the original extension)
	// because the language server is watching the file system for Python
	// file add/delete/change and we don't want this temp file to trigger it.
	let fileName = `${document.uri.fsPath}.${md5(document.uri.fsPath)}.tmp`;
	try {
	// When dealing with untitled notebooks, there's no original physical file, hence create a temp file.
	if (isNotebookCell(document.uri) && !(await fs.fileExists(document.uri.fsPath))) {
	fileName = (await fs.createTemporaryFile(`${path.basename(document.uri.fsPath)}.tmp`)).filePath;
	}
	await fs.writeFile(fileName, document.getText());
	} catch (ex) {
	traceError('Failed to create a temporary file', ex);
	throw new WrappedError(`Failed to create a temporary file, ${ex.message}`, ex);
	}
	return fileName;
	}