Strip UTF8 BOM from device id - #315679
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Copilot model-fetch failure caused by a UTF-8 BOM (U+FEFF) appearing at the start of telemetry.devDeviceId, which breaks header construction (ByteString conversion) in fetch.
Changes:
- Sanitize the device ID returned by
@vscode/deviceidby stripping a leading UTF-8 BOM before returning it.
Show a summary per file
| File | Description |
|---|---|
src/vs/base/node/id.ts |
Strips a leading UTF-8 BOM from the device ID returned by @vscode/deviceid to prevent invalid header values. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Dmitriy Vasyura (dmitrivMS)
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #315612