Skip to content

Add missing NotifyIcon notification constant - #1769

Open
Rafael Rivera (riverar) wants to merge 3 commits into
mainfrom
rafael/notifyicon_msgs
Open

Add missing NotifyIcon notification constant#1769
Rafael Rivera (riverar) wants to merge 3 commits into
mainfrom
rafael/notifyicon_msgs

Conversation

@riverar

@riverar Rafael Rivera (riverar) commented Dec 18, 2023

Copy link
Copy Markdown
Collaborator

Fixes: #1765

@mikebattista

Copy link
Copy Markdown
Contributor

What's blocking it from being int?

@riverar

Copy link
Copy Markdown
Collaborator Author

Mike Battista (@mikebattista) I didn't fully explore that rabbit hole, but I think we'll need to change WM_USER and all the NIN_ msgs to int and then fix all the collateral damage. 😅

@riverar

Copy link
Copy Markdown
Collaborator Author

Interesting, made the change locally again and doesn't seem as bad. Will update this PR shortly.

@riverar
Rafael Rivera (riverar) marked this pull request as draft December 18, 2023 19:48
@riverar
Rafael Rivera (riverar) marked this pull request as ready for review December 18, 2023 21:20
@riverar

Copy link
Copy Markdown
Collaborator Author

Looks like AzDO has given up on builds. Mike Battista (@mikebattista)

@mikebattista

Copy link
Copy Markdown
Contributor

All the other WM_ constants are uint. Are there side effects of making WM_USER int but not the others? Feels like this should cause some usability problems somewhere.

@riverar

Copy link
Copy Markdown
Collaborator Author

Yeah, I think there's a larger "naked constants should default to int not uint" discussion to be had here.

@mikebattista

Copy link
Copy Markdown
Contributor

Looks like AzDO has given up on builds. Mike Battista (@mikebattista)

Thanks. I believe it should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NIN_KEYSELECT missing

2 participants