Add missing NotifyIcon notification constant - #1769
Add missing NotifyIcon notification constant#1769Rafael Rivera (riverar) wants to merge 3 commits into
Conversation
|
What's blocking it from being int? |
|
Mike Battista (@mikebattista) I didn't fully explore that rabbit hole, but I think we'll need to change WM_USER and all the NIN_ msgs to int and then fix all the collateral damage. 😅 |
|
Interesting, made the change locally again and doesn't seem as bad. Will update this PR shortly. |
|
Looks like AzDO has given up on builds. Mike Battista (@mikebattista) |
|
All the other WM_ constants are uint. Are there side effects of making WM_USER int but not the others? Feels like this should cause some usability problems somewhere. |
|
Yeah, I think there's a larger "naked constants should default to int not uint" discussion to be had here. |
Thanks. I believe it should be fixed now. |
01f35c4 to
579cc3e
Compare
Fixes: #1765