Skip to content

Missing CanReturnMultipleSuccessValues for IShellLinkA and IShellLinkW for GetPath and GetIDList. Fixed microsoft#2279. - #2280

Merged
Jevan Saks (jevansaks) merged 3 commits into
microsoft:mainfrom
PrototypeNM1:fix-shelllink
Aug 25, 2026
Merged

Missing CanReturnMultipleSuccessValues for IShellLinkA and IShellLinkW for GetPath and GetIDList. Fixed microsoft#2279.#2280
Jevan Saks (jevansaks) merged 3 commits into
microsoft:mainfrom
PrototypeNM1:fix-shelllink

Conversation

@PrototypeNM1

Copy link
Copy Markdown
Contributor

No description provided.

@jevansaks
Jevan Saks (jevansaks) enabled auto-merge (squash) July 27, 2026 17:59

@jevansaks Jevan Saks (jevansaks) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the ChangesSInceLastRelease.txt update

@jevansaks

Copy link
Copy Markdown
Member

Oh, right, I removed that step. Nevermind. :)

@PrototypeNM1

Nicholas Rishel (PrototypeNM1) commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

PR Validation looks like a false positive?

@jevansaks

Copy link
Copy Markdown
Member

PR Validation looks like a false positive?

I was on vacation, taking a look...

@github-actions

Copy link
Copy Markdown

📋 API Surface Diff

+4 additions / -0 deletions vs main branch (full validation run)

Click to expand API diff
diff --git "a/bin\\baseline.apidump.cs" "b/bin\\current.apidump.cs"
index 955e3d9f..c4ce0b9e 100644
--- "a/bin\\baseline.apidump.cs"
+++ "b/bin\\current.apidump.cs"
@@ -904407,9 +904407,11 @@ namespace Windows.Win32.UI.Shell;
 [Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nn-shobjidl_core-ishelllinka")]
 public interface IShellLinkA : IUnknown
 {
+	[CanReturnMultipleSuccessValues]
 	[Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinka-getpath")]
 	unsafe HRESULT GetPath ([Out][NativeArrayInfo (CountParamIndex = 1)] PSTR pszFile, [In] int cch, [In][Out] WIN32_FIND_DATAA* pfd, [In] uint fFlags);
 
+	[CanReturnMultipleSuccessValues]
 	[Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinka-getidlist")]
 	unsafe HRESULT GetIDList ([Out] ITEMIDLIST** ppidl);
 
@@ -904578,9 +904580,11 @@ namespace Windows.Win32.UI.Shell;
 [Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nn-shobjidl_core-ishelllinkw")]
 public interface IShellLinkW : IUnknown
 {
+	[CanReturnMultipleSuccessValues]
 	[Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinkw-getpath")]
 	unsafe HRESULT GetPath ([Out][NativeArrayInfo (CountParamIndex = 1)] PWSTR pszFile, [In] int cch, [In][Out] WIN32_FIND_DATAW* pfd, [In] uint fFlags);
 
+	[CanReturnMultipleSuccessValues]
 	[Documentation ("https://learn.microsoft.com/windows/win32/api/shobjidl_core/nf-shobjidl_core-ishelllinkw-getidlist")]
 	unsafe HRESULT GetIDList ([Out] ITEMIDLIST** ppidl);
 

This comment is automatically updated on each push.

@jevansaks
Jevan Saks (jevansaks) merged commit 019f85a into microsoft:main Aug 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants