Polish project restore output modes - #791
Conversation
Honor quiet verbosity during project restores, avoid duplicate verbose invocations, and document JSON and quiet routing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
de57385 to
3c6fd63
Compare
2526b8c to
00665be
Compare
Use scoped disposal for the JSON and quiet restore stderr capture writers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Polishes project-mode restore output across default, verbose, quiet, JSON, and interactive modes.
Changes:
- Applies quiet verbosity to restore commands when appropriate.
- Removes duplicate verbose restore-command traces while retaining redacted invocation output.
- Adds regression tests and updates user/setup documentation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ProjectRunService.cs |
Resolves restore verbosity and simplifies debug traces. |
ProjectRunService.Arguments.cs |
Supports optional restore verbosity arguments. |
ProjectRunServiceTests.cs |
Tests quiet and JSON restore routing. |
plugins/winapp/skills/winapp-setup/SKILL.md |
Documents output-mode behavior. |
docs/usage.md |
Clarifies restore/build verbosity and routing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Build Metrics ReportBinary Sizes
Test Results✅ 4621 passed, 5 skipped out of 4626 tests in 567.1s (+5 tests, -190.4s vs. baseline) Test Coverage✅ 89.1% line coverage, 82.4% branch coverage · ✅ no change vs. baseline CLI Startup Time47ms median (x64, Try This BuildInstalls the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing. & ([scriptblock]::Create((irm https://github.com/ghraw/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 791Switching between builds often?Put the tool on your PATH once: & ([scriptblock]::Create((irm https://github.com/ghraw/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPathThen this build is just: winapp-pr 791Run Updated 2026-08-26 23:46:12 UTC · commit |
PR ReviewDecisionMerge. No critical or high issues. I confirmed all four output modes behave as the updated docs describe by running the published CLI against a real WinUI app. One optional test-quality nit below. Must fixNone — mergeable as-is. Non-blockingThe new
|
Zach Teutsch (zateutsch)
left a comment
There was a problem hiding this comment.
Review was fully clean for me.
|
Superseded by #789, which now includes the output-mode polish and all follow-up review fixes. |
Summary
dotnet restorewhile preserving default, JSON, and interactive terminal behaviorValidation
dotnet test src\winapp-CLI\WinApp.Cli.Tests\WinApp.Cli.Tests.csproj -c Release --filter "FullyQualifiedName~ProjectRunServiceTests"(195 passed).\scripts\validate-plugin-package.ps1git diff --check.\scripts\build-cli.ps1reached NativeAOT publish, then stopped at the machine's known missing Desktop Development for C++ linker prerequisite