feat: Allow checking statuscodes of batch response without parsing step body#626
Merged
andrueastman merged 2 commits intoMar 15, 2023
Merged
Conversation
svrooij
requested review from
MIchaelMainer,
andrueastman,
peombwa and
zengin
as code owners
March 15, 2023 11:10
andrueastman
left a comment
Contributor
There was a problem hiding this comment.
Thanks again for this.
andrueastman
approved these changes
Mar 15, 2023
andrueastman
enabled auto-merge
March 15, 2023 14:19
|
Thanks @svrooij again, for the proposed enhancements! |
Contributor
Author
|
@maisarissi does Microsoft also have a digital badge for "brilliant ideas"? And the mean reason for this latest PR was that we are faced with a limit of 4 requests when trying to modify TodoTasks. Where should I post about that issue? |
Merged
|
Hey @svrooij . I'm not aware of such badge, but we are working on a new program related to SDKs :) Once the program is ready, we will communicate how things are going to work. |
This was referenced Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #621
Changes proposed in this pull request
GetResponsesStatusCodesAsync()for BatchResponseContentCollection and BatchResponseContent that allows checking the status codes without creating HttpResponseMessage for each step (that has to be disposed)BatchRequestStepsfor BatchRequestContentCollection so you can possibly fetch the failed steps to retry, for instance in case of some429results in the batch.BatchRequestContentCollectionincluding the number of requests that may be combined. (At the moment you cannot combine more then 4 requests, when creating TodoTasks, all above 4 fail with 429.) This allows the user to use batching without having to manage smaller batches himself.Other links
@maisarissi I've made batching even better to also support getting the failing steps.
Microsoft Reviewers: Open in CodeFlow