feat(storybook): add Colors example page#2
Merged
Conversation
Add a new Colors page under Examples that displays all theme colors with their CSS variables, hex values, and Tailwind classes. - Primary color scale (50-950) - Semantic colors (background, foreground, card, muted, border, etc.) - Status colors (destructive, success, warning) - Click-to-copy functionality for all values - Dark mode values shown where different - Usage examples for CSS and Tailwind
garrity-miepub
added a commit
that referenced
this pull request
Feb 11, 2026
Address 5 of 7 review comments from the Copilot pull request reviewer on PR #89, with the remaining 2 acknowledged as intentional deferrals. Changes: 1. Replace Math.random() with React.useId() for gridIdRef (line 214) - Eliminates SSR/hydration mismatch risk by producing deterministic, stable IDs across server and client renders. - Colons in useId() output are sanitized to hyphens for DOM id compatibility. 2. Fix useEffect dependency array (line 467) - Replaced manual [source.type, source.url, JSON.stringify(source.data)] with [initializeDataVis, destroyInstances]. - initializeDataVis is a useCallback that already captures source, viewOptions, gridOptions, and all callback props in its deps, so the effect now correctly re-triggers when ANY of those change. - Previously, viewOptions/gridOptions updates were silently ignored. - Removes both eslint-disable comments for react-hooks/exhaustive-deps. 3. Remove JSON.stringify(source.data) from dependency array (line 467) - Resolved automatically by fix #2 above. - Eliminates the risk of expensive serialization on large datasets and potential throws on circular structures. 4. Remove unused dv-brand-* CSS class names from brand variants (line 99) - No corresponding CSS rules existed anywhere in the repo. - Brand theming is handled entirely via CSS custom properties set by ThemeProvider, making these class names dead code. - All brand variant values set to empty strings (preserving the variant type system for future use). 5. Fix import specifier mismatch with peer dependency (line 315) - Now tries import('@mieweb/wcdatavis') first, matching the declared peerDependency name. - Falls back to import('wcdatavis') for local dev (file: dep) and Storybook (Vite alias to shim). - Consumers who install the scoped package no longer need custom build aliases. Deferred (not changed, explained in PR review comments): - datavis-theme.css not in dist/: DataVis not yet in tsup entry points. - file: devDependency: Intentional local dev workflow; CI uses stubs.
garrity-miepub
added a commit
that referenced
this pull request
May 1, 2026
- StepIndicator: add aria-label to step circle buttons (button-name) - Slider: move hidden input outside role="slider" div (nested-interactive) - BusinessHoursEditor story: add tabIndex + role to scrollable pre (scrollable-region-focusable) - Timeline: add aria-label to progressbar (aria-progressbar-name) - Dashboard story: disable DataVis NITRO ARIA rules per-story (upstream library) - AudioPlayer: fix time display contrast (text-muted-foreground → text-neutral-600) - Sidebar story: add aria-label to collapse buttons (button-name)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new Colors page under Examples that displays all theme colors with their CSS variables, hex values, and Tailwind classes.
colors.mov