Skip to content

Fix release lockfile version check - #21

Merged
shps951023 merged 1 commit into
mainfrom
fix/release-package-lock-json
Sep 15, 2026
Merged

shps951023 merged 1 commit into
mainfrom
fix/release-package-lock-json

Conversation

@shps951023

@shps951023 shps951023 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • parse web-demo/package-lock.json with ConvertFrom-Json -AsHashtable
  • support npm's empty-string root package key under current PowerShell
  • unblock the existing v0.5.0 tag release without moving or replacing the tag

The initial v0.5.0 Release run failed in Verify tag and package versions before any crate or GitHub asset was published: https://github.com/mini-software/MiniExcel-Rust/actions/runs/34971361676

After this merges, rerun the Release workflow with workflow_dispatch and tag=v0.5.0.

Validation

  • full local release version contract passed for v0.5.0
  • actionlint .github/workflows/release.yml
  • VS Code workflow diagnostics: no errors
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Improved release verification to reliably read the Browser Lab lockfile version during automated checks.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: f90c9b50-cd0b-4de1-b6a0-8ac05052d281

📥 Commits

Reviewing files that changed from the base of the PR and between a37d808 and 7b4f232.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The release verification job now parses web-demo/package-lock.json as a hashtable before extracting its version.

Changes

Release workflow

Layer / File(s) Summary
Lockfile version extraction
.github/workflows/release.yml
The workflow uses ConvertFrom-Json -AsHashtable before reading the version key from the lockfile.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 7b4f2

The release verification workflow now supports the lockfile format required for the v0.5.0 release, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing the release workflow's lockfile version check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-package-lock-json

Comment @coderabbitai help to get the list of available commands.

@shps951023
shps951023 merged commit 6e166c9 into main Sep 15, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant