Fix NuGet source repository links - #148
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe NuGet metadata URLs in the CLI and library project files now point to the ChangesRepository metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The next package release will reference the corrected MiniPdf repository URLs, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🟡 Changes recommended
The NuGet-packaged readme files referenced by these projects still contain old shps951023/MiniPdf links, so the NuGet-facing repository/source links are not fully corrected.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates NuGet package metadata so the MiniPdf and MiniPdf.Cli packages point to the canonical mini-software/MiniPdf GitHub repository, ensuring correct repository links for future published versions.
Changes:
- Updated
PackageProjectUrlforMiniPdftohttps://github.com/mini-software/MiniPdf. - Updated
PackageProjectUrlforMiniPdf.Clitohttps://github.com/mini-software/MiniPdf. - Updated
RepositoryUrlfor both packages tohttps://github.com/mini-software/MiniPdf.git.
File summaries
| File | Description |
|---|---|
| src/MiniPdf/MiniPdf.csproj | Updates NuGet package project/repository URLs to the mini-software/MiniPdf repo. |
| src/MiniPdf.Cli/MiniPdf.Cli.csproj | Updates NuGet package project/repository URLs to the mini-software/MiniPdf repo. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| <PackageProjectUrl>https://github.com/mini-software/MiniPdf</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/mini-software/MiniPdf.git</RepositoryUrl> |
| <PackageProjectUrl>https://github.com/mini-software/MiniPdf</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/mini-software/MiniPdf.git</RepositoryUrl> |
Summary
PackageProjectUrlforMiniPdfandMiniPdf.Clito themini-software/MiniPdforganization repositoryRepositoryUrlfor both packages to the matching Git repository URLNuGet packages are immutable, so the existing
0.41.1package metadata cannot be replaced. The corrected Source repository link will appear starting with the next published version.Validation
Packed both projects with a temporary version and inspected the generated
.nuspecfiles:MiniPdf: project and repository URLs point tomini-software/MiniPdfMiniPdf.Cli: project and repository URLs point tomini-software/MiniPdfgit diff --check origin/main...HEADSummary by CodeRabbit