Add content part support in prep for multi-modal embedding models - #27
Merged
Conversation
Release 0.5.0 with vision support
zackangelo
approved these changes
Jul 22, 2026
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe protocol now shares media input modeling between append and embed requests, supports ordered text/media embedding content, and adds round-trip tests for URI and blob media. The crate version and repository ignore rules are also updated. ChangesEmbedding protocol support
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shape of this matches media for
SeqAppend- from the modelsocket perspective it's something like:{ "request": "seq_command", "cid": "embed-1", "seq_id": "seq-123", "data": { "command": "embed", "inputs": [ { "content": [ { "text": "Find products similar to this bicycle" }, { "media": { "uri": "https://example.com/bicycle.png", "mime_type": "image/png", "detail": "high" } } ] } ], "input_type": "image", "dimensions": 1024, "normalize": true, "truncate": false } }Summary by CodeRabbit
New Features
Bug Fixes
Chores