Skip to content

Pass cid/seq_id as structured meta instead of as a value in the errors - #30

Merged
chrisboulton merged 2 commits into
mainfrom
errors
Jul 29, 2026
Merged

Pass cid/seq_id as structured meta instead of as a value in the errors#30
chrisboulton merged 2 commits into
mainfrom
errors

Conversation

@chrisboulton

@chrisboulton chrisboulton commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

There's probably a few others that we should consider doing the same for, but unknown seq_id is the bulk of the unnormalised noise we see.

Summary by CodeRabbit

  • Refactor
    • Improved diagnostic logging for unmatched sequence IDs and callback identifiers using structured fields.
    • No user-facing behavior changes.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 18a912e1-3fb7-413f-a128-8e52e08f3948

📥 Commits

Reviewing files that changed from the base of the PR and between 977521b and 5e08248.

📒 Files selected for processing (1)
  • src/client/mod.rs

📝 Walkthrough

Walkthrough

Client error logs now emit seq_id and cid as structured tracing fields instead of interpolating them into message strings.

Changes

Structured tracing updates

Layer / File(s) Summary
Client error log fields
src/client/mod.rs
The forward_to_seq and on_seq_opened error logs record seq_id and cid through structured tracing fields.

Estimated code review effort: 1 (Trivial) | ~2 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch errors

Comment @coderabbitai help to get the list of available commands.

@chrisboulton
chrisboulton merged commit b32621f into main Jul 29, 2026
15 of 16 checks passed
@chrisboulton
chrisboulton deleted the errors branch July 29, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants